Stop painting full-width grey spacer rows on user messages - #318
Merged
TheGreatAxios merged 2 commits intoAug 5, 2026
Merged
Conversation
Blank user-banner rows no longer fill the terminal width with background color, which could flash as a solid grey block during scroll/repaint. Closes CL-5345
Collaborator
Author
Code review (parent — multi-agent fleet unavailable)Verdict: approve — minimal, correct fix for the grey-block artifact. Correctness
Risks / nits
Tests
|
Collaborator
Author
Review — approveSmall, targeted fix for the intermittent full-width grey flash on user banners. Verdict: approve Notes
Risks / test gaps
Merge conflicts
|
Collaborator
Author
Multi-agent review (blended: cto / greybeard / neckbeard / critique / bruckheimer)Verdict: Approve Findings
Ready for human review/merge. |
Collaborator
Author
Hard review (greybeard + CTO)Verdict: APPROVE GreybeardOne-line assembly change: stop painting full-width grey spacer rows on user messages. Minimal blast radius. CTOShip. If residual grey appears later, it is a different path — file a new ticket. No blockers. |
plainLines always yields at least one row, so the length check never skipped empty user messages. Trim-gate emptiness instead, and assert spacer rows stay unpainted while body rows keep userMessageBg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes CL-5345