Guide first-run onboarding with numbered step copy - #321
Merged
Conversation
Show step N of M, field-specific guidance, and a post-setup hint so new installs are less guesswork during provider setup. Closes CL-5347
Collaborator
Author
Code review (parent — multi-agent fleet unavailable)Verdict: approve for first slice; issue scope is broader Correctness
Gaps vs issue outcome
Nits
|
Collaborator
Author
Review — approveSmall, focused first-run copy improvement. No functional risk. Notes
Gaps
Verdict: approve — good to merge as-is. |
4 tasks
Collapse step copy so errors still fit on small terminals, and point users at /model instead of the incorrect Ctrl+A and /models bindings.
Collaborator
Author
Multi-agent review (blended: cto / greybeard / neckbeard / critique / bruckheimer)Verdict: Approve (after post-review fix) Fixed from review
Ready for human review/merge. |
Collaborator
Author
Hard review (greybeard + CTO)Verdict: APPROVE GreybeardNumbered first-run steps are copy-only guidance — no new control flow. Low risk. CTOShip. Follow-up polish can live elsewhere if we want richer onboarding later. No blockers. |
Match FIELD_HINTS to the step guidance catalog (openai, anthropic, ollama) and add a unit test that the provider-setup step banner renders on mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes CL-5347