Skip to content

Guide first-run onboarding with numbered step copy - #321

Merged
TheGreatAxios merged 3 commits into
mainfrom
cl-5347-guide-first-run-onboarding
Aug 5, 2026
Merged

Guide first-run onboarding with numbered step copy#321
TheGreatAxios merged 3 commits into
mainfrom
cl-5347-guide-first-run-onboarding

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • First-run provider setup shows Step N of M and field-specific guidance
  • Adds a post-setup hint for Ctrl+A / /models
  • Makes cold start less guesswork

Test plan

  • Fresh install (no provider) shows welcome + step progress
  • Each field shows contextual next-step guidance
  • Enter/Esc still advance/back through fields and save works

Closes CL-5347

Show step N of M, field-specific guidance, and a post-setup hint so new
installs are less guesswork during provider setup.

Closes CL-5347
@linear-code

linear-code Bot commented Aug 5, 2026

Copy link
Copy Markdown

CL-5347

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Code review (parent — multi-agent fleet unavailable)

Verdict: approve for first slice; issue scope is broader

Correctness

  • Step N of M + field-specific guidance improves cold-start clarity.
  • Post-setup Ctrl+A / /models hint is useful.
  • Does not force a wizard on already-configured users (only runOnboarding path).

Gaps vs issue outcome

  • Issue also wants guidance for invalid settings and connect when needed on the main path. This PR only improves the unconfigured-provider panel. Pair with CL-5348 (fail-open diagnostics) for the invalid-settings half.

Nits

  • No tests (copy-only). Optional snapshot of ProviderSetupPanel would lock the step labels.

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Review — approve

Small, focused first-run copy improvement. No functional risk.

Notes

  • Step N of M + per-field guidance is clear; Enter/Esc flow untouched.
  • Mild redundancy: numbered guidance (1.4.) plus FIELD_HINTS on the active field — fine for cold start.
  • Post-setup hint (Ctrl+A / /models) is always visible during setup; acceptable.

Gaps

Verdict: approve — good to merge as-is.

Collapse step copy so errors still fit on small terminals, and point
users at /model instead of the incorrect Ctrl+A and /models bindings.
@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Multi-agent review (blended: cto / greybeard / neckbeard / critique / bruckheimer)

Verdict: Approve (after post-review fix)

Fixed from review

  • Onboarding step copy tightened so error + guidance still fit on small terminals.
  • Post-setup shortcut text corrected to /model (was incorrect Ctrl+A / /models).

Ready for human review/merge.

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Hard review (greybeard + CTO)

Verdict: APPROVE

Greybeard

Numbered first-run steps are copy-only guidance — no new control flow. Low risk.

CTO

Ship. Follow-up polish can live elsewhere if we want richer onboarding later.

No blockers.

Match FIELD_HINTS to the step guidance catalog (openai, anthropic, ollama)
and add a unit test that the provider-setup step banner renders on mount.
@TheGreatAxios
TheGreatAxios merged commit 0f30d67 into main Aug 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant