Log durability failures instead of swallowing catches - #326
Merged
Conversation
Collaborator
Author
Hard review (greybeard + CTO)Verdict: APPROVE GreybeardHigh-priority durability catches now log; settings write-back paths stop silent clobber; resume hydrate and crash finalize are no longer black holes. Medium catch sites got the same treatment without turning intentional queue-chain silence into noise. CTOThis is ops hygiene that pays for itself the first time saveState fails in the wild. Ship with the 5351 set. No blockers. |
CL-5351 slice A: surface saveState/post-run, settings write-back, resume hydrate, and crash-finalize failures without clobbering files.
Surface Codex refresh, pricing seed/refresh, teardown close, and non-ENOENT settings load failures at least as debug/warn logs. Profile unlink ignores ENOENT only. Keep non-throwing fire-and-forget behavior.
max-concurrent and wait-for-approval paths already used loadGlobalSettingsWriteBase but returned silently on null. Match the plugin/compaction/session-mode warn with path.
TheGreatAxios
force-pushed
the
cl-5351-durability-catches
branch
from
August 5, 2026 06:14
f7d2cc2 to
4288c24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saveStateanddispatchPostRunnow log (and post-run notes stderr)loadRecentTurnsfailures log + surface a one-line transcript error blockContext
Part of CL-5351 (durability catches only). Hooks and IIFE cleanups are separate PRs (#324, #325).
Test plan
bun run typecheckbun test ./tests/unit/exec/runner.test.ts ./tests/unit/tui/runner.test.ts ./src/settings.test.ts