Paint the full retained transcript instead of a smaller window - #345
Merged
TheGreatAxios merged 1 commit intoAug 7, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-5553-transcript-history-past-500-rows-cannot-be-scrolled-to
branch
from
August 7, 2026 05:17
f66b290 to
78d5d98
Compare
The stream log is already capped at a fixed number of retained rows with an absolute base index threaded through every touch point, so a second, smaller paint window on top of that cap was redundant: painting every retained row is what makes all of it reachable by scrolling, and it composes with the retention cap instead of duplicating it. The paint tree now rebuilds directly from the retained log (no separate windowing pass or collapse marker). Appending a row adds one node and removes only what the retention trim actually evicted. Replacing a row in place — the streaming-token path — still resolves to a single-node retext once eviction has started; the row-children helper now excludes the eviction notice by node identity rather than by array length, so the notice's presence can never make that check look like a broken mapping and force a full rebuild. Evicted rows get a notice above the oldest retained one, updated in place rather than rebuilt, so the boundary reads as dropped rather than as the true start of history. Deleted the old windowing helpers and their dedicated test file — once the log itself is capped, nothing calls them.
TheGreatAxios
force-pushed
the
cl-5553-transcript-history-past-500-rows-cannot-be-scrolled-to
branch
from
August 7, 2026 05:35
78d5d98 to
257eb95
Compare
TheGreatAxios
deleted the
cl-5553-transcript-history-past-500-rows-cannot-be-scrolled-to
branch
August 7, 2026 06:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheckandbun run buildcleanbun run test(the package'sbun test ./src ./tests ./evals): 3946 pass / 0 fail across 303 files, two consecutive runssrc/tui-opentui/transcript-long-log-scroll.test.ts: scrolling to the top of a 650-row session reaches row 50 (oldest retained), not row 49 (evicted), with the "50 earlier rows dropped" notice present; appending past the cap evicts at most one painted node; the eviction notice retexts in place across repeated evictions;replaceStreamRowAtcalled once after eviction has started removes at most one painted node (was 601 before this fix — the eviction notice's presence made the row-children length check permanently look like a broken mapping, forcing a full rebuild on every streamed token past the cap)Closes CL-5553