Show corbits.dev and GitHub links on OAuth success screen - #379
Merged
Conversation
Show corbits.dev and github.com/corbitsdev next to the product name on the authorization callback page so the success screen points operators at the public brand surfaces. Fixes CL-5604
TheGreatAxios
force-pushed
the
cl-5604-callback-links-v2
branch
2 times, most recently
from
August 8, 2026 19:08
dd3b3c6 to
e17a48c
Compare
The URLs lived in branding.ts while their display text stayed inline in the page template, so a rename would have had to touch both. Add matching label constants and restore the no-external-assets guard to its full strength by stripping the two intentional footer links before asserting no other off-machine URL or network call appears.
TheGreatAxios
force-pushed
the
cl-5604-callback-links-v2
branch
from
August 8, 2026 19:16
e17a48c to
4d7f52b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes CL-5604