Stop the stall watchdog from aborting healthy parallel tool fan-outs - #383
Merged
TheGreatAxios merged 1 commit intoAug 8, 2026
Merged
Conversation
awaitingResponse flips true the instant any one tool call in a parallel fan-out finishes, even while sibling calls are still running. The stall check treated that flag alone as proof of silence, so a multi-agent run with real work in flight got a false stall notice at 90s and a hard abort at 900s, killing every still-running sub-agent. Outstanding tool calls now suppress both the notice and the abort.
Collaborator
Author
|
Root-cause follow-up filed per Greybeard's review: CL-5661 (https://linear.app/abklabs/issue/CL-5661) — turn-state.ts's tool.done handler sets awaitingResponse unconditionally instead of gating on remaining activeToolCalls like inference.done/connector.reply already do. This PR's fix at the watchdog layer is correct and matches the Linear acceptance criteria; CL-5661 tracks fixing the underlying asymmetry at the source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
awaitingResponseflips true the instant any one tool call in a parallel fan-out finishes, even while sibling calls are still runningactiveToolCallsintoShouldAbortForStallArgsso outstanding tool calls suppress both the notice and the abort; genuine stalls (no active calls) still abort as beforeTest plan
awaitingResponse: true+ 20-minute-stalelastActivityAt->shouldAbortForStallfalse,shouldNoticeStallfalse; confirmed it failed before the fixbun run typecheck— only pre-existing, unrelatedvendor/intx-inference/arktype errorsbun run build— passesbun run test— 4080 pass, 1 pre-existing environment-dependent failure (lsp-availability.test.ts, unrelated to this change)