Fix the doc-drift cluster from the 2026-08-08 audit - #387
Merged
Conversation
The doc described a hard abort at 3 idle turns with a specific error string that does not exist in src/. The real mechanism auto-pauses (not aborts) at a model-family-dependent tool-only-turn threshold and resumes on the next operator message, matching what ARCHITECTURE.md's "Main-session loop protection" section already describes correctly.
The section described the permission system as fully wired. Two of the three disconnects an earlier design review found (project-grant cwd matching, grant-driven queue reconciliation) are already fixed and merged, so this only calls out what remains live: queued-gate timers arm at emit time instead of display time, and ask_operator has no timeout/abort safety net, both in gate-wire.ts.
…rface The three-row table only ever named the two events the turn-boundary guards care about, but its heading and placement read as an enumeration of the reactor's event vocabulary — and IMPLEMENTATION.md kept a second, differently partial list with no cross-reference. Retitle the table, point both docs at PRODUCTION_REACTOR_TYPES in stream-event-map.ts as the one canonical list, and drop IMPLEMENTATION.md's separate enumeration.
IMPLEMENTATION.md's File Structure section listed six of the nine docs/ files, missing TUI.md, TELEMETRY.md, and PERFTRACE.md. Separately, docs/plans/ holds design-decision write-ups (including the current authoritative source on live permission-system gaps) but wasn't mentioned anywhere in AGENTS.md's Reference table, so an agent following AGENTS.md's own "read /docs first" instruction had no way to discover it.
…nter Greybeard and Critique both caught the same defect: the new prose claimed the table names "only the two events reactor-events.ts guards for" while the table itself still had three rows, including tool.done (which reactor-events.ts doesn't guard). Rewrote the prose to say why tool.done is there instead of asserting a count the table contradicts. Also corrected the PRODUCTION_REACTOR_TYPES line citation, carried over wrong from the audit doc (66-80 -> 62-78 in both ARCHITECTURE.md and IMPLEMENTATION.md).
The pause text in PRODUCT.md and ARCHITECTURE.md was a paraphrase presented as a quotation; it never matched director.ts. The hardcoded "15 types" count would drift the same way the lists this PR replaced did.
TheGreatAxios
force-pushed
the
cl-5667-doc-drift-cluster
branch
from
August 8, 2026 19:06
654f0eb to
0430ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan