Extract a shared resolveDefaultModel helper - #389
Merged
Conversation
…lback The defaultModel-or-first-model precedence was hand-rolled at three call sites (providers.ts:86, inference-sources.ts:43, settings.ts:1074), so a rule change at one site wouldn't apply at the others and the active and backup model for the same provider could diverge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveDefaultModelin src/config/providers.ts and wired all three call sites to it, so the active and backup model for a provider can no longer divergeTest plan
bun test src/config/providers.test.ts(new resolveDefaultModel cases, RED before implementation, GREEN after)bun run typecheck(no new errors introduced)bun run buildbun run test(4143 pass, 1 pre-existing unrelated failure in lsp-availability.test.ts due to missing devDependencies in this worktree)