Remove dead matchGlob, parsePresentViewFromArgs, and lookupModelReasoning - #392
Merged
TheGreatAxios merged 1 commit intoAug 8, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-5679-dead-code-cleanup-isapproved-adjacent-orphaned-exports
branch
from
August 8, 2026 18:57
81fbbda to
d002502
Compare
…ning Each had zero production importers, referenced only by its own dedicated test. matchGlob was src/util/glob.ts:41 (whole file removed, its only other function globToRegex existed solely to support it); parsePresentViewFromArgs was src/tui/tool-args.ts (whole file removed); lookupModelReasoning was src/cost/pricing-fetcher.ts:183-185.
TheGreatAxios
force-pushed
the
cl-5679-dead-code-cleanup-isapproved-adjacent-orphaned-exports
branch
from
August 8, 2026 19:14
d002502 to
290fa70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchGlob(src/util/glob.ts:41, whole file removed since its only helper existed to support it),parsePresentViewFromArgs(src/tui/tool-args.ts, whole file removed), andlookupModelReasoning(src/cost/pricing-fetcher.ts:183-185).isApprovedinsrc/permission/matcher.tswas intentionally left untouched: the ticket text itself notes it has active-matcher consequences beyond dead code and is tracked separately (grant-scoping-filter ticket), so it was excluded from this bundle despite appearing in the original task list.Test plan
bun run typecheck— pre-existing unrelated errors only (tool-formatter.ts, list-dir.ts, vendor/intx-inference), none in touched filesbun run buildlsp-availability.test.ts, environment-dependent LSP detection againstprocess.cwd())