Keep the landing mountain painted through startup load notices - #393
Merged
Conversation
MCP connection failures, hook failures, and width-contract warnings called appendStreamRow directly, which cleared the landing mark and wiped the mountain hero the moment anything went wrong on load. These notices now ride the notice strip via surfaceStartupNotice while the landing is still mounted, and flush into the transcript as durable rows once the first real session row ends the landing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendStreamRowdirectly on load, which cleared the landing mark and wiped the mountain herosurfaceStartupNotice, which rides the notice strip while the landing is mounted and flushes deferred rows into the transcript once the first real session row ends the landingTest plan
bun run typecheckbun run buildbun run test(4140 pass, 0 fail)