Validate the project trust store's shape with arktype - #394
Merged
TheGreatAxios merged 2 commits intoAug 8, 2026
Merged
Conversation
project-trust.ts hand-rolled typeof checks for a JSON shape identical in kind to the one path-trust.ts already validates via arktype. The array fields stay typed as unknown[] rather than string[], since this store must keep valid string entries out of a mixed-type array instead of rejecting the whole record, unlike path-trust.ts's stricter schema.
TheGreatAxios
force-pushed
the
cl-5678-project-trustts-hand-rolls-json-validation-that-duplicates
branch
from
August 8, 2026 18:57
71a371f to
d29669a
Compare
The arktype object schema accepts arrays (they are typeof "object"), so a trust-store file containing a bare JSON array silently degraded to an empty-but-valid store instead of being flagged invalid. Explicit Array.isArray check restores the original rejection before validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan