Keep the landing intact when a plugin warns at startup - #414
Closed
TheGreatAxios wants to merge 1 commit into
Closed
Keep the landing intact when a plugin warns at startup#414TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
A startup plugin warning went out through appendStreamRow, whose first statement is clearLandingMark — so one warning took the whole landing hero with it: the mark, the hints beside it, the composition. A first run in any repo with an unresolved skill showed no landing at all. CL-5618 routed MCP and hook failures through surfaceStartupNotice for this exact reason. Plugin diagnostics were the path it missed. Also drops the internal gutter labels these rows carried. "command" is plumbing, not a word an operator would use for what they are reading. And dedupes the summary: one skill referenced by three plugins produced three warnings, so seven missing skills printed as nine entries and the count disagreed with the list.
Collaborator
Author
|
Closing in favour of I patched the one flush site. That branch found that That is the right shape and the same lesson as the grep/secret-scrub finding: a cross-cutting constraint applied at call sites is one forgotten call site away from being false. It also removes the three |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A startup plugin warning went out through
appendStreamRow, whose first statement isclearLandingMark— so one warning took the whole landing hero with it: the mark, the hints beside it, the composition. A first run in any repo with an unresolved skill showed no landing at all.CL-5618 routed MCP and hook failures through
surfaceStartupNoticefor exactly this reason; its comment says so outright. Plugin diagnostics were the path it missed.What changed
startupPluginNoticesride the notice strip instead of the transcriptcommandgutter label is gone from system rows — plumbing, not a word an operator would use for what they are readingformatPluginWarningsSummarydedupes: one skill referenced by three plugins produced three warnings, so seven missing skills printed as nine entries and the count disagreed with the listScope
The bug half of CL-5718, split out so it lands now. The composition work — snow, changelog-on-fresh-install, the ranked notice register, short-terminal degradation — continues separately against the mockups on the ticket. Three
meta: "palette"labels remain and belong with that pass.