Drop the nightly random-seed test job - #418
Merged
Merged
Conversation
The job only ran on a schedule, so on every pull request it surfaced as a skipped check that contributed nothing but a line of noise to the status list. Ordering leaks are still caught: the fixed-seed randomized run stays in the main check, where a failure blocks the merge that caused it instead of being reported hours later against an unrelated commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the scheduled
randomize-nightlyjob and the cron trigger that existed only to fire it.It never ran on a pull request, so its only effect there was a permanently skipped check in the status list. Ordering leaks remain covered by the fixed-seed randomized run in the main check, which blocks the merge that introduces one rather than reporting it the next morning against an unrelated commit.