Skip to content

Clear the MCP auth banner after mid-session re-authentication succeeds - #433

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-5793-clear-mcp-auth-banner-after-successful-authentication
Aug 9, 2026
Merged

Clear the MCP auth banner after mid-session re-authentication succeeds#433
TheGreatAxios merged 1 commit into
mainfrom
cl-5793-clear-mcp-auth-banner-after-successful-authentication

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Mid-session MCP re-auth was leaving the standing "needs auth" banner up even after OAuth completed successfully.
  • After interactive OAuth and the retried operation both succeed, re-emit a connected status for servers that already have tools registered so the banner clears.
  • Cover the notify-only-on-success retry helper and assert the painted frame drops "needs auth" once connected lands.

Test plan

  • bun test ./src/mcp/client-auth-retry.test.ts ./src/tui-opentui/runtime-channels.test.ts
  • bun run typecheck
  • bun run test (full suite, 4325 pass)

Refs CL-5793

Re-emit connected status once interactive OAuth and the retried MCP
operation both succeed, so standing needs-auth chrome does not stick
around after tools are already registered.
@linear-code

linear-code Bot commented Aug 9, 2026

Copy link
Copy Markdown

CL-5793

@TheGreatAxios
TheGreatAxios merged commit 1be723d into main Aug 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant