Skip to content

Fix dual @intx/types identity so local typecheck matches CI - #448

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-5855-fix-dual-intxtypes-identity-so-local-typecheck-matches-ci
Aug 10, 2026
Merged

Fix dual @intx/types identity so local typecheck matches CI#448
TheGreatAxios merged 1 commit into
mainfrom
cl-5855-fix-dual-intxtypes-identity-so-local-typecheck-matches-ci

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Pin @intx/types / @intx/types/* in root tsconfig.json paths to vendor/intx-types so TypeScript always sees one identity.
  • Document that Bun overrides handle install/runtime resolution while paths are required for tsc when a nested published @intx/types@0.2.2 reappears under packages like @intx/agent.

Fixes CL-5855.

Why

Clean bun install already links agent → vendor via workspace overrides. A stale or partial layout can still leave published @intx/types@0.2.2 nested under @intx/agent, and tsc then treats vendor PendingOperation (has kind) and published PendingOperation (no kind) as incompatible types — local typecheck fails while CI (clean install) stays green.

Approach

tsconfig paths + existing overrides (minimal durable fix):

  • Overrides keep install-time links on vendor.
  • Paths force a single TypeScript-visible identity even if nested published types reappear.

Evidence

After clean install in this worktree:

  • node_modules/@intx/typesvendor/intx-types
  • node_modules/.bun/@intx+agent@…/node_modules/@intx/typesvendor/intx-types
  • No @intx+types@0.2.2 package slot under .bun
  • bun run typecheck exit 0

Forced dual filesystem layout (agent nested types = published cache copy):

  • Without paths: assignability errors on PendingOperation.kind, directors, context stores, compactors
  • With paths: bun run typecheck exit 0

Test plan

  • Clean bun install → single realpath for top-level and agent-nested @intx/types (vendor)
  • bun run typecheck passes on clean install
  • bun run typecheck still passes with forced nested published @intx/types@0.2.2 under agent
  • CI typecheck green on this PR

Bun overrides already point install-time resolution at vendor/intx-types,
but a nested published @intx/types@0.2.2 under @intx/agent can still give
tsc a second type identity (missing PendingOperation.kind and related
shapes). Pin tsconfig paths at the vendor source so local typecheck
matches CI regardless of that layout, and document both layers.
@TheGreatAxios TheGreatAxios added bug Something isn't working high priority Land soon; blocks local typecheck / developer velocity labels Aug 10, 2026
@linear-code

linear-code Bot commented Aug 10, 2026

Copy link
Copy Markdown

CL-5855

@TheGreatAxios
TheGreatAxios merged commit 2f4fe7b into main Aug 10, 2026
2 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-5855-fix-dual-intxtypes-identity-so-local-typecheck-matches-ci branch August 10, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working high priority Land soon; blocks local typecheck / developer velocity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant