Stop stamping changelog watermark without showing notes (CL-5475) - #449
Merged
TheGreatAxios merged 1 commit intoAug 10, 2026
Conversation
The OpenTUI path computed whatsNewMarkdown and stamped lastChangelogVersion as a side effect, but never rendered the notes — upgrades were permanently marked seen without display. Stamp first-install only; upgrade stamps only when notesShown is true (currently false until a surface returns).
TheGreatAxios
deleted the
cl-5475-dead-whats-new-path-still-stamps-the-changelog-watermark
branch
August 10, 2026 02:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastChangelogVersionwithout ever rendering on the OpenTUI path (deadwhatsNewMarkdown).stampVersionAfterStartup(decision, notesShown)so policy is unit-tested and a future surface can flipnotesShownto true.Approach
Stop stamping (not restore surface). The former Ink whats-new banner is gone; stamping without display permanently swallowed notes.
/changelogremains available on demand.Test plan
bun test src/changelog/index.test.tsbun run typecheckbun run test(4481 pass)stampVersionAfterStartup:Closes CL-5475