Make the ripgrep stdout byte cap deterministic across platforms - #450
Merged
TheGreatAxios merged 1 commit intoAug 10, 2026
Merged
Conversation
Close could settle as complete output before the last stdout chunk was handled, so Linux CI never tripped the cap. Defer close one turn so queued data runs first, and re-check the cap at every settle path so an over-cap body can never be reported as a full success.
TheGreatAxios
deleted the
cl-5550-ripgrep-output-cap-does-not-trip-on-linux-ci
branch
August 10, 2026 02:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closecould settle a ripgrep run as complete output before the last stdout chunk was handled, so the byte cap never tripped.setImmediateturn so queueddatahandlers run first, and re-checks the cap on every settle path (close,timeout) so an over-cap body can never be reported as a full success.Closes CL-5550
Test plan
bun test src/plugins/rg-output.test.ts src/plugins/rg-run.test.ts tests/unit/ripgrep-plugin.test.ts(22 pass)bun run typecheckgrep returns partial matches when the output byte cap is hit