Architecture docs hygiene for permission queue + events (CL-5668, CL-5669) - #451
Merged
Merged
Conversation
CL-5669 Events hygiene already landed on main. CL-5668 asked for a temporary known-gaps callout to CL-5662/5663/5664, but those grants/timer bugs are Done or superseded — keep the permission section truthful without permanent known-issue debt: describe queue reconciliation, worktree-aware project grants, and point at gate-wire/permission queue instead of deleted use-gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/ARCHITECTURE.mdpermission section truthful after CL-5662 / CL-5663 / CL-5664 fixed or superseded: document headless grant reconciliation (src/permission/queue.ts), worktree-aware project grants, and point the wall-clock budget paragraph atgate-wire+ permission queue instead of deleteduse-gates.use-gates/pendingPlanplan-approval sentence fromdocs/IMPLEMENTATION.md.PRODUCTION_REACTOR_TYPESas canonical); no further Events change needed.Why not a known-gaps callout
CL-5668 originally asked for a temporary pointer to CL-5662/5663/5664. Those are Done (5662, 5664) or Canceled/superseded (5663 → CL-4995). House policy: no permanent known-issue debt for closed tickets — describe the fixed behavior instead.
Test plan
docs/ARCHITECTURE.md,docs/IMPLEMENTATION.md)use-gates/pendingPlan/ permanent known-gap callouts — none remain in these filesPRODUCTION_REACTOR_TYPESinsrc/tui/stream-event-map.tsCloses CL-5668
Closes CL-5669