Skip to content

Add approval-overlay overflow conformance tests - #452

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-5694-approval-overlay-overflow-behavior-has-no-conformance-test
Aug 10, 2026
Merged

Add approval-overlay overflow conformance tests#452
TheGreatAxios merged 1 commit into
mainfrom
cl-5694-approval-overlay-overflow-behavior-has-no-conformance-test

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Pins CL-4612 short-terminal overflow guarantees for permission and operator overlays
  • Asserts viewport height/offset and choice reachability (not transcript substrings)
  • Covers direct overlay openers and gate-wire paths

Closes CL-5694

Note: docs/plans/cutover-regression-sweep.md is gitignored; mark CL-4612 STILL HOLDS locally after merge.

Test plan

  • bun test src/tui/overlay-overflow.test.ts (8 pass)
  • CI green

Pin CL-4612 short-terminal guarantees: viewport shrinks under the host
fraction cap, every choice stays reachable by navigation, and gate-wire
permission/operator paths still resolve the selected outcome. Asserts
viewport/offset state so a clamp regression fails the suite.
@linear-code

linear-code Bot commented Aug 10, 2026

Copy link
Copy Markdown

CL-5694

@TheGreatAxios
TheGreatAxios merged commit a9521e4 into main Aug 10, 2026
2 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-5694-approval-overlay-overflow-behavior-has-no-conformance-test branch August 10, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant