Harden Wave 2 picker and compaction review follow-ups - #464
Merged
Conversation
Model accept now uses the filtered row id only, empty filter sentinels cannot toggle favorites, and re-read stubbing only considers kept turns with path+offset+limit identity so chunked reads stay whole. Docs, changelog, and executable bit for the vendored patch ledger catch up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 2 multi-agent review follow-ups after PRs #458–#463:
id(no unfiltered-index fallback); empty(no matches)id cannot select or Alt+F-favorite; JSDoc/docs match flat type-to-filter; j/k filter note in TUI.md; suite rename + coverage for no-matches / filtered accept / Alt+F sentinelkeepRecentTurnsaligned to 6; strategy version 1.3.1bin/vendor-patch-diffexecutable bitTest plan
bun run typecheckbun test ./tests/unit/compactor-pairing.test.ts ./src/tui/product-host.test.ts ./src/context-compactor.test.tsbun run test(4503 pass)