Clean review nits before the next cut - #465
Merged
Merged
Conversation
Single-source keepRecentTurns, honest copy flash (only after a successful clipboard write), scheduleUpgradeNotice coverage, and stale Ink/type-to-filter comment fixes from the multi-agent pass.
Leave the flash gated on write success/failure, but drop the highlight immediately so a slow clipboard helper cannot pin the selection. Cover writeClipboard settlement paths and latch upgrade-notice tests on the fetch promise instead of a fixed sleep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release cleanup from the multi-agent audit of
v0.2.95..HEAD. No product features — nits only.DEFAULT_COMPACTOR_CONFIG.keepRecentTurnsderives fromCOMPACTOR_KEEP_RECENT_TURNS(single literal).writeClipboard— flashCopied …only on success;Copy failedon reject/throw; still clears highlight. Alt+C paths use the same helper.scheduleUpgradeNoticeavailable / quiet / notify-throw.Test plan
bun teston selection-copy, upgrade, copy-wire, compactor-pairing, context-compactor (76 pass)bun run typecheck