Skip to content

Support unlimited named API-key provider instances - #470

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-5898-support-unlimited-named-api-key-provider-instances
Aug 10, 2026
Merged

Support unlimited named API-key provider instances#470
TheGreatAxios merged 1 commit into
mainfrom
cl-5898-support-unlimited-named-api-key-provider-instances

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • First-class API-key providers now name an instance before the key (same multi-instance model as OAuth accounts).
  • Instances store as kind/slug catalog rows so a second key cannot silently overwrite the first; reusing a name confirms before replace.
  • Alt+A account counts include API-key instances; Custom remains free-form.

Closes CL-5898.

Verification

  • bun run typecheck
  • bun run build
  • bun run test (4541 pass, 0 fail)

Notes

  • Legacy bare keys (e.g. openai) still count as the default slug and are updated in place on confirmed reconnect.

First-class API-key connects now ask for an instance name before the key,
matching OAuth multi-account naming. Instances land as kind/slug catalog
rows so a second key cannot silently overwrite the first; reusing a name
confirms before replace.
@linear-code

linear-code Bot commented Aug 10, 2026

Copy link
Copy Markdown

CL-5898

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critique

Lens: behavioral correctness and multi-instance safety
Verdict: approve
Summary: First-class API-key connects name instances before the key and store kind/slug catalog rows so a second key cannot overwrite the first; confirmed reuse updates in place, including legacy bare keys.

Findings: none.

Greybeard

Lens: architecture and documentation alignment
Verdict: approve
Summary: Reuses the OAuth multi-instance slug machinery (oauthProfile, suggest/confirm) for API-key kinds without pulling Custom into that path; PRODUCT/TUI/CHANGELOG describe the shipped behavior.

Findings: none.

gaasbot

Lens: public OSS / release readiness
Verdict: approve
Summary: UX, tests, and docs are contributor-readable; no secrets, machine paths, or private assumptions land in the tree.

Findings: none.

@TheGreatAxios
TheGreatAxios merged commit 120a900 into main Aug 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant