Persist project provider selection after API-key connect - #472
Merged
TheGreatAxios merged 1 commit intoAug 10, 2026
Merged
Conversation
TheGreatAxios
commented
Aug 10, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Critique
Lens: selection-persistence contract across auth kinds
Verdict: approve
Summary: API-key and Custom connects write project-local provider/model selection via the same submit helper as OAuth; secrets stay in global settings.
Findings: none.
Greybeard
Lens: architecture and dead-plumbing cleanup
Verdict: approve
Summary: cwd is removed from connect input; callers pass an explicit localSettingsPath, removing the accepted-but-ignored drift.
Findings: none.
gaasbot
Lens: public OSS / release readiness
Verdict: approve
Summary: Regression tests cover restart resolution and secret isolation; docs/changelog match the behavior.
Findings: none.
TheGreatAxios
force-pushed
the
cl-5900-api-key-connect-should-persist-the-projects-selected
branch
from
August 10, 2026 18:37
e948010 to
ce06634
Compare
API-key and Custom connects now write the project-local provider/model selection the same way OAuth does, so a restart keeps the connected model without storing secrets in the per-repo file.
TheGreatAxios
force-pushed
the
cl-5900-api-key-connect-should-persist-the-projects-selected
branch
from
August 10, 2026 18:42
ce06634 to
471f69e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes CL-5900.
Verification
bun run typecheckbun run buildbun run test(4541 pass, 0 fail)