Recover resume transcript when a turns segment has malformed JSON - #479
Closed
TheGreatAxios wants to merge 1 commit into
Closed
Recover resume transcript when a turns segment has malformed JSON#479TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
…tory Resume hydrate used loadRecentTurns, which aborted the whole segment on one mid-file null hole or garbage line. Display-only recovery now skips bad lines and still paints usable turns; fully unrecoverable segments name the file in the error. Reactor ContextStore.load still hard-fails.
Collaborator
Author
|
Closing as superseded by #480, which landed the writer root-cause fix (no more null-padding on stale #479 only soft-recovered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadRecentTurns) now skips mid-file null holes and non-tail malformed JSONL lines so surrounding history still paints.ContextStore.load()still hard-fails (display-only recovery only).Test plan
bun test src/session/optimized-context-store.test.ts(14 pass)bun run typecheckbun run buildbun run test(4550 pass, 0 fail)Fixes CL-5935