Persist yolo as the user-global skip-permissions default - #500
Merged
TheGreatAxios merged 3 commits intoAug 22, 2026
Merged
Conversation
Collaborator
Author
TheGreatAxios
commented
Aug 22, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Self-review
Verdict: ship with should-fix. No blocking functional defect in the diff. /yolo live-flips then persists as the user-global default; next launch seeds from settings without the flag; --dangerously-skip-permissions still forces this process on. Secret-guard and authz are untouched.
Should-fix
- Persist wrap is untested. Schema and
loadConfigseed are covered;/yolo→saveGlobalSettingsis not. Missing: on writestrue, off writesfalse, unreadable settings still live-flips and notices. /yolo offis unproven on the read path. Round-trip tests only usetrue. Merge isflag || settings?.dangerouslySkipPermissions === true.- Exec inherits the sticky default with no
--no-…. After/yolo on, latercorbits execskips the gate.docs/PRODUCT.mdstill says exec fail-closes unless the CLI flag is set — that paragraph is now wrong.
Nits
- Success copy does not mention persist.
- Persist is unsynchronized RMW; overlapping
/yolovs otherpersistGlobalSettingscallers can last-write-win. --configTUI/yolowrites the override file, not~/.corbits/settings.json(same as compaction / showPromptCost).- No CHANGELOG Unreleased note for a user-facing safety default.
CommandContextJSDoc still says “for the rest of the session”.
Will land these in a follow-up commit on this PR.
TheGreatAxios
force-pushed
the
cl-6685-persist-yolo-as-a-global-default-not-session-only
branch
from
August 22, 2026 20:07
fb7057f to
418891f
Compare
TheGreatAxios
force-pushed
the
cl-6685-persist-yolo-as-a-global-default-not-session-only
branch
from
August 22, 2026 20:45
98229c1 to
bf3925f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/yolo(on/off/toggle) writes skip-permissions as the user-global default so later sessions start in that stance without--dangerously-skip-permissionsVerification
bun run typecheckandbun run buildpassbun run test: 4990 pass; 2 fail in grok-4.6 reasoning-effort cycling (unrelated to this change; those tests expecthigh→low, implementation advances toxhigh)Fixes CL-6685