Treat missing project-trust repo field as invalid - #509
Merged
TheGreatAxios merged 1 commit intoAug 22, 2026
Merged
Conversation
A store without repo skipped the mismatch guard entirely and was accepted as valid, applying its grants to whatever cwd hashed to that filename.
TheGreatAxios
changed the base branch from
cl-6705-make-project-trust-saves-atomic-and-serialized
to
main
August 22, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo-mismatch guard in readProjectTrustStore only ran when repo was present, so a store file without it was accepted as valid and its grants applied to whatever cwd hashed to that filename. Now a missing or non-string repo yields state: "invalid" and empty grants, matching valid-store behavior of requiring resolved repo === resolved cwd.
Fixes CL-6709. Stacked on #506.
https://linear.app/abklabs/issue/CL-6709