Preserve repo defaultEnabled through plugin dedupe shadowing - #510
Merged
TheGreatAxios merged 1 commit intoAug 22, 2026
Merged
Conversation
A later non-repo install sharing a repo defaultEnabled plugin's id would win the last-wins dedupe, and the survivor's non-repo origin then failed isPluginModuleEnabled's origin check, silently turning off the bundled default. dedupePluginModules now stamps the surviving module with shadowedRepoDefaultEnabled when it replaces a repo defaultEnabled entry, and isPluginModuleEnabled honors that stamp unless settings explicitly disable the id.
TheGreatAxios
changed the base branch from
cl-6714-honor-plugin-defaultenabled-for-agents-tools-still-require
to
main
August 22, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin discovery dedupe was last-wins by id, so a later non-repo install sharing a repo defaultEnabled plugin's id would win and lose the origin:repo signal, silently turning the bundled default off. dedupePluginModules now stamps the surviving module with shadowedRepoDefaultEnabled when it shadows a repo defaultEnabled entry, and isPluginModuleEnabled honors that stamp unless settings explicitly disable the id.
Fixes CL-6716. Stacked on #507.
https://linear.app/abklabs/issue/CL-6716