Key project trust stores by realpath to unify symlink twins - #514
Merged
TheGreatAxios merged 1 commit intoAug 22, 2026
Merged
Conversation
The store filename hash, repo field, mutation-queue key, and plugin-path resolution all keyed off the lexical resolved cwd, so the same repo reached through a symlink twin (e.g. macOS /tmp vs /private/tmp) hashed to a different store file and lost its grants. Canonicalize cwd through realpath (falling back to lexical resolve when the path doesn't exist yet) everywhere it's used to key or compare. Fixes CL-6721 https://linear.app/abklabs/issue/CL-6721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonicalizes cwd through realpath (falling back to lexical resolve when the path doesn't exist) everywhere project-trust.ts keys or compares a project path: the store filename hash, the repo field, the mutation-queue key (via projectTrustPath), and plugin-path resolution. Adds a regression test that creates a real directory plus a symlink to it in a temp home and confirms grants written via one spelling are found via the other.
Fixes CL-6721
https://linear.app/abklabs/issue/CL-6721