Return canonical realpath from workspace containment allow - #516
Merged
TheGreatAxios merged 2 commits intoAug 22, 2026
Merged
Conversation
resolveWorkspacePath already computes each candidate's realpath to decide containment but returned the lexical path, leaving a TOCTOU window: a symlink in-bounds at allow time could be retargeted before the actual write, escaping the workspace. Return the resolved real path instead so pathEscapePlugin substitutes it into the tool call args, and writers act on the already-resolved location rather than re-traversing the symlink. Fixes CL-6712 https://linear.app/abklabs/issue/CL-6712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveWorkspacePath already realpath's each candidate to decide containment but returned the lexical (symlink-intact) path to callers, leaving a TOCTOU window: a symlink that is in-bounds at allow time could be retargeted before the actual write/read, escaping the workspace. It now returns the canonical real path so pathEscapePlugin substitutes it into the tool call's path argument before write_file/edit_file/delete_file run, so the writer acts on the already-resolved location instead of re-traversing the symlink.
Fixes CL-6712
https://linear.app/abklabs/issue/CL-6712