Deny dangling symlink components in nearest-realpath walks - #518
Merged
TheGreatAxios merged 2 commits intoAug 22, 2026
Merged
Conversation
realpathNearestOr treated a realpath failure as an always-missing tail and rejoined the raw component name, so a dangling symlink under cwd whose target didn't exist yet was reattached as a normal path segment and read as in-bounds. Now lstat distinguishes "doesn't exist at all" (safe, missing tail) from "exists but unresolvable" (dangling link or symlink loop), and the latter denies via resolveWorkspacePath/underRoot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realpathNearestOr's ambiguous realpath failure treated a dangling symlink's name as a normal missing-tail segment, so containment could see a symlink under cwd pointing outside as in-bounds before its target existed. lstat now distinguishes a genuinely missing component from one that exists but can't resolve (dangling link/loop), denying the latter in resolveWorkspacePath and underRoot.
Fixes CL-6715
https://linear.app/abklabs/issue/CL-6715