Refresh slash popup in place instead of close+reopen - #519
Merged
TheGreatAxios merged 3 commits intoAug 22, 2026
Merged
Conversation
openSlashCommands closed and reopened the palette overlay on every filter keystroke, and closeSlashPopup routes through closeInsetOverlay which fires notifyOverlayClosed — releasing the host long enough for a queued permission/operator gate to drain onto it mid-typing. Mirror the @-mention popup fix (PR #515): when the slash popup is already open, refresh its items via setOverlayItems instead, leaving priorOverlay stacking untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slash typeahead refreshed by fully closing then reopening the palette overlay on every filter keystroke; closeSlashPopup routes through closeInsetOverlay, which fires notifyOverlayClosed and can drain a queued permission/operator gate mid-typing. This mirrors the merged @-mention fix (#515): when the slash popup is already open, openSlashCommands now refreshes items via setOverlayItems in place, leaving priorOverlay stacking untouched.
Fixes CL-6699
https://linear.app/abklabs/issue/CL-6699