Restore node:fs after the Codex instructions unit mock - #530
Merged
Conversation
The instructions test replaced node:fs for the whole process and never put it back. CI loads ./src before ./tests, so every later suite that touches the real filesystem saw the in-memory fake — missing settings files, ENOENT fixture reads, and chmod on paths mkdir never created. Spread the real module into the mock and restore it in afterAll, matching the pattern already used by the session state tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:fsfor the whole process and never restored it../srcbefore./tests, so later suites hit the in-memory fake (settings.jsonmissing, fixture ENOENT,chmodon pathsmkdirnever created).afterAll, matching the session state test pattern.build-and-testonmain(red since Refresh Codex instructions on exec boot and record eval diagnostics #526) and therefore PRs Give successful leaf task completions backstop progress credit #503 / Live-clock in-flight tool rows, clear stale stall notice #529.Verification
bun run teston CIRelated to CL-6693