Name the failing segment in extra-segment load errors - #568
Merged
TheGreatAxios merged 1 commit intoAug 23, 2026
Merged
Conversation
parseSegmentTurns omitted fileName at the extra-segment call sites (loadTurnsWithoutMalformedToolSequence and readAt), so corruption in turns-0001.jsonl and later segments fell back to the generic "turns segment" label. Thread the segment name through both call sites.
TheGreatAxios
enabled auto-merge
August 23, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-6960.
parseSegmentTurns takes an optional fileName used to name the file in error messages. The reactor's load() passed it for the base segment, but the extra-segment path (loadTurnsWithoutMalformedToolSequence -> parseSegmentTurns, and readAt) omitted it, so corruption in turns-0001.jsonl and later segments fell back to the generic "turns segment has malformed JSON at line N" label instead of naming the file.
Threaded the segment name through both call sites that were missing it. Added a test that reproduces malformed content in turns-0001.jsonl and asserts store.load() rejects with a message containing that segment's filename, and stays strict (does not skip/soften the error).
Test plan