Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/agent/directors/brand-reviewer/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@ describe("brandReviewerPackage", () => {
expect(brandReviewerPackage.systemPrompt).not.toMatch(/authz/i);
});

test("report.requiredSections covers the leaf envelope", () => {
const sections = brandReviewerPackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is docs", () => {
expect(brandReviewerPackage.modelRole).toBe("docs");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/brand-reviewer/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export const brandReviewerPackage: DirectorPackage = {
tools: { allow: DOCS_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "docs",
systemPrompt: `You are BrandReviewerDirector, a specialist in Corbits Code.

Expand Down
6 changes: 0 additions & 6 deletions src/agent/directors/bruckheimer/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ describe("bruckheimerPackage", () => {
expect(bruckheimerPackage.writePaths).toBeUndefined();
});

test("report requires envelope sections", () => {
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
expect(bruckheimerPackage.report.requiredSections).toContain(section);
}
});

test("modelRole is docs", () => {
expect(bruckheimerPackage.modelRole).toBe("docs");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/bruckheimer/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export const bruckheimerPackage: DirectorPackage = {
tools: { allow: DOCS_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "docs",
systemPrompt: `You are BruckheimerDirector, a specialist in Corbits Code.

Expand Down
8 changes: 0 additions & 8 deletions src/agent/directors/build/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,6 @@ describe("buildDirectorPackage", () => {
expect(allow).toContain("apply_patch");
});

test("report.requiredSections includes Summary, Findings, Blockers, Paths", () => {
const sections = buildDirectorPackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is implement", () => {
expect(buildDirectorPackage.modelRole).toBe("implement");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/build/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export const buildDirectorPackage: DirectorPackage = {
tools: { allow: BUILD_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 60 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "implement",
systemPrompt: `You are BuildDirector, a specialist in Corbits Code.

Expand Down
8 changes: 0 additions & 8 deletions src/agent/directors/critique/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,6 @@ describe("critiquePackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report.requiredSections covers the leaf envelope", () => {
const sections = critiquePackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is review", () => {
expect(critiquePackage.modelRole).toBe("review");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/critique/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export const critiquePackage: DirectorPackage = {
tools: { allow: REVIEW_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 45 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "review",
systemPrompt: `You are CritiqueDirector, a specialist in Corbits Code.

Expand Down
8 changes: 0 additions & 8 deletions src/agent/directors/draper/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ describe("draperPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report.requiredSections covers the leaf envelope", () => {
const sections = draperPackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is review", () => {
expect(draperPackage.modelRole).toBe("review");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/draper/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export const draperPackage: DirectorPackage = {
tools: { allow: REVIEW_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "review",
systemPrompt: `You are DraperDirector, a specialist in Corbits Code.

Expand Down
8 changes: 0 additions & 8 deletions src/agent/directors/emil/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ describe("emilPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report.requiredSections covers the leaf envelope", () => {
const sections = emilPackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is review", () => {
expect(emilPackage.modelRole).toBe("review");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/emil/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export const emilPackage: DirectorPackage = {
tools: { allow: REVIEW_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "review",
systemPrompt: `You are EmilDirector, a specialist in Corbits Code.

Expand Down
8 changes: 0 additions & 8 deletions src/agent/directors/explore/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ describe("explorePackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report.requiredSections covers the leaf envelope", () => {
const sections = explorePackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is explore", () => {
expect(explorePackage.modelRole).toBe("explore");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/explore/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ Report: Summary, Findings, Blockers, Paths.`,
tools: { allow: READ_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 35 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "explore",
};
6 changes: 0 additions & 6 deletions src/agent/directors/gaasbot/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ describe("gaasbotPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report requires envelope sections", () => {
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
expect(gaasbotPackage.report.requiredSections).toContain(section);
}
});

test("modelRole is plan", () => {
expect(gaasbotPackage.modelRole).toBe("plan");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/gaasbot/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export const gaasbotPackage: DirectorPackage = {
tools: { allow: REVIEW_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 35 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "plan",
systemPrompt: `You are GaasbotDirector, a specialist in Corbits Code.

Expand Down
6 changes: 0 additions & 6 deletions src/agent/directors/greybeard/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@ describe("greybeardPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report requires envelope sections", () => {
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
expect(greybeardPackage.report.requiredSections).toContain(section);
}
});

test("modelRole is review", () => {
expect(greybeardPackage.modelRole).toBe("review");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/greybeard/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export const greybeardPackage: DirectorPackage = {
allowlist: ["intern", "explore", "critique"],
},
nudge: { maxTurns: 50 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "review",
systemPrompt: `You are GreybeardDirector, a specialist in Corbits Code.

Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ export {
type DirectorPackage,
type ModelRole,
type NudgePolicy,
type ReportContract,
type ResolveDirectorInput,
type ResolveDirectorResult,
type SpawnRights,
Expand Down
6 changes: 0 additions & 6 deletions src/agent/directors/intern/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ describe("internPackage", () => {
}
});

test("report.requiredSections envelope", () => {
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
expect(internPackage.report.requiredSections).toContain(section);
}
});

test("modelRole is implement", () => {
expect(internPackage.modelRole).toBe("implement");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/intern/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export const internPackage: DirectorPackage = {
tools: { allow: INTERN_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 20 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "implement",
systemPrompt: `You are InternDirector, a specialist in Corbits Code.

Expand Down
6 changes: 0 additions & 6 deletions src/agent/directors/neckbeard/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ describe("neckbeardPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report requires envelope sections", () => {
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
expect(neckbeardPackage.report.requiredSections).toContain(section);
}
});

test("modelRole is review", () => {
expect(neckbeardPackage.modelRole).toBe("review");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/neckbeard/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export const neckbeardPackage: DirectorPackage = {
tools: { allow: REVIEW_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "review",
systemPrompt: `You are NeckbeardDirector, a specialist in Corbits Code.

Expand Down
6 changes: 0 additions & 6 deletions src/agent/directors/plan/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ describe("planPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report requires envelope sections", () => {
for (const section of ["Summary", "Findings", "Blockers", "Paths"]) {
expect(planPackage.report.requiredSections).toContain(section);
}
});

test("modelRole is plan", () => {
expect(planPackage.modelRole).toBe("plan");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/plan/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export const planPackage: DirectorPackage = {
tools: { allow: REVIEW_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "plan",
systemPrompt: `You are PlanDirector, a specialist in Corbits Code.

Expand Down
3 changes: 0 additions & 3 deletions src/agent/directors/registry.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ describe("director registry", () => {
expect(pkg.systemPrompt.length).toBeGreaterThan(40);
expect(pkg.systemPrompt.startsWith("Placeholder")).toBe(false);
expect(pkg.systemPrompt.toLowerCase()).toContain("primary intent");
expect(pkg.report.requiredSections).toEqual(
expect.arrayContaining(["Summary", "Findings", "Blockers", "Paths"]),
);
}
});

Expand Down
8 changes: 0 additions & 8 deletions src/agent/directors/shakespeare/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ describe("shakespearePackage", () => {
expect(shakespearePackage.writePaths).toBeUndefined();
});

test("report.requiredSections includes Summary, Findings, Blockers, Paths", () => {
const sections = shakespearePackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is docs", () => {
expect(shakespearePackage.modelRole).toBe("docs");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/shakespeare/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,5 @@ export const shakespearePackage: DirectorPackage = {
tools: { allow: DOCS_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 50 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "docs",
};
9 changes: 0 additions & 9 deletions src/agent/directors/skywalker/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,6 @@ describe("skywalkerPackage", () => {
expect(allow).toContain("delete_file");
});

test("report required sections", () => {
expect(skywalkerPackage.report.requiredSections).toEqual([
"Summary",
"Findings",
"Blockers",
"Paths",
]);
});

test("modelRole is orchestrator", () => {
expect(skywalkerPackage.modelRole).toBe("orchestrator");
});
Expand Down
3 changes: 0 additions & 3 deletions src/agent/directors/skywalker/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,5 @@ export const skywalkerPackage: DirectorPackage = {
],
},
nudge: { maxTurns: 100 },
report: {
requiredSections: ["Summary", "Findings", "Blockers", "Paths"],
},
modelRole: "orchestrator",
};
8 changes: 0 additions & 8 deletions src/agent/directors/tester/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,6 @@ describe("testerPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report.requiredSections includes Summary, Findings, Blockers, Paths", () => {
const sections = testerPackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is test", () => {
expect(testerPackage.modelRole).toBe("test");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/tester/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ Report: Summary, Findings (commands + results), Blockers, Paths.`,
tools: { allow: READ_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "test",
};
8 changes: 0 additions & 8 deletions src/agent/directors/testsmith/package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,6 @@ describe("testsmithPackage", () => {
expect(allow).not.toContain("delete_file");
});

test("report.requiredSections includes Summary, Findings, Blockers, Paths", () => {
const sections = testsmithPackage.report.requiredSections;
expect(sections).toContain("Summary");
expect(sections).toContain("Findings");
expect(sections).toContain("Blockers");
expect(sections).toContain("Paths");
});

test("modelRole is test", () => {
expect(testsmithPackage.modelRole).toBe("test");
});
Expand Down
1 change: 0 additions & 1 deletion src/agent/directors/testsmith/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,5 @@ Report: Summary, Findings (strategy + cases), Blockers, Paths.`,
tools: { allow: READ_TOOLS },
spawn: { maySpawn: false },
nudge: { maxTurns: 40 },
report: { requiredSections: ["Summary", "Findings", "Blockers", "Paths"] },
modelRole: "test",
};
6 changes: 0 additions & 6 deletions src/agent/directors/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ export interface NudgePolicy {
readonly stallMs?: number;
}

export interface ReportContract {
/** Required top-level sections in the worker report. */
readonly requiredSections: readonly string[];
}

/**
* One shipped director: hard primary intent + package fields.
* Packages land in later levels; registry holds the closed set.
Expand Down Expand Up @@ -80,7 +75,6 @@ export interface DirectorPackage {
readonly writePaths?: readonly string[];
readonly spawn: SpawnRights;
readonly nudge?: NudgePolicy;
readonly report: ReportContract;
readonly modelRole: ModelRole;
}

Expand Down
Loading
Loading