Skip to content

Remove unreachable AgentProfile.fleetTier - #606

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-6983-agentprofilefleettier-is-unreachable-no-loader-reads-it-from
Aug 24, 2026
Merged

Remove unreachable AgentProfile.fleetTier#606
TheGreatAxios merged 1 commit into
mainfrom
cl-6983-agentprofilefleettier-is-unreachable-no-loader-reads-it-from

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • AgentProfile.fleetTier was declared in the schema and read at one site (task-tool.ts), but no loader (markdown frontmatter, JS plugin profiles, default agents) ever populated it — every profile-sourced agent resolved to leaf.
  • Deleted the field from AgentProfileSchema / AgentProfile, and the read site in task-tool.ts. run.ts fail-closed behavior is unchanged: an unresolved tier still resolves to leaf and is still denied fleet verbs (task/search_agents).
  • Removed the stale comment claiming fleetTier avoided a naming collision with an AgentProfile.tier field — that field never existed in the schema.
  • Updated docs/ARCHITECTURE.md and added a CHANGELOG.md entry under [Unreleased].

Test plan

  • bun test tests/unit/subagent.test.ts src/subagent/run-authority.test.ts src/profiles.test.ts — added an assertion that a profile-sourced orchestrator still has an unresolved orchestratorTier (fail-closed).
  • bun run check (lint, typecheck, build, full test suite) — all green.

No loader ever populated it from any config format, so profile-sourced
orchestrators always resolved to leaf. Fail-closed denial of fleet verbs
is unchanged; CL-6942/CL-6944 can add a real opt-in when a caller needs one.
@linear-code

linear-code Bot commented Aug 24, 2026

Copy link
Copy Markdown

CL-6983

@TheGreatAxios
TheGreatAxios enabled auto-merge (squash) August 24, 2026 06:42
@TheGreatAxios
TheGreatAxios merged commit 9c6a703 into main Aug 24, 2026
5 checks passed
TheGreatAxios added a commit that referenced this pull request Aug 27, 2026
No loader ever populated it from any config format, so profile-sourced
orchestrators always resolved to leaf. Fail-closed denial of fleet verbs
is unchanged; CL-6942/CL-6944 can add a real opt-in when a caller needs one.
TheGreatAxios added a commit that referenced this pull request Aug 27, 2026
No loader ever populated it from any config format, so profile-sourced
orchestrators always resolved to leaf. Fail-closed denial of fleet verbs
is unchanged; CL-6942/CL-6944 can add a real opt-in when a caller needs one.
@TheGreatAxios
TheGreatAxios deleted the cl-6983-agentprofilefleettier-is-unreachable-no-loader-reads-it-from branch August 28, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant