Resolve fleetRecords on cancel so wait_agents sees salvage - #672
Merged
Conversation
Operator cancel aborts the child signal, but run() can still return a salvage body. The spawn settle path used to drop that body when childCtl was aborted, leaving fleetRecords "running" forever so wait_agents never observed the salvage. Always resolve/reject fleetRecords; complete/fail already no-op when the strip is cancelled. Complementary to #668 (content salvage into the forced-stop envelope).
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…672) Operator cancel aborts the child signal, but run() can still return a salvage body. The spawn settle path used to drop that body when childCtl was aborted, leaving fleetRecords "running" forever so wait_agents never observed the salvage. Always resolve/reject fleetRecords; complete/fail already no-op when the strip is cancelled. Complementary to #668 (content salvage into the forced-stop envelope).
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…672) Operator cancel aborts the child signal, but run() can still return a salvage body. The spawn settle path used to drop that body when childCtl was aborted, leaving fleetRecords "running" forever so wait_agents never observed the salvage. Always resolve/reject fleetRecords; complete/fail already no-op when the strip is cancelled. Complementary to #668 (content salvage into the forced-stop envelope).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator cancel aborts the child signal, but
run()can still return a salvage body. The spawn settle path previously dropped that body whenchildCtlwas aborted, leavingfleetRecords"running" forever sowait_agentsnever observed the salvage. Alwaysresolve/rejectfleetRecords;complete/failalready no-op when the strip is cancelled.Relationship to #668
Complementary to #668 (content salvage into the forced-stop envelope). This PR is the fleetRecords/wait_agents side of CL-6915 — it does not duplicate #668's Findings/Paths salvage changes.
Test plan
spawn_agentstill resolveswait_agentswith salvage findings while strip stays cancelledCloses CL-6915