Make director task a spawn plus wait wrapper - #685
Merged
Conversation
TheGreatAxios
force-pushed
the
fleet-task-wrapper
branch
from
August 25, 2026 14:49
a1ea789 to
241e46c
Compare
TheGreatAxios
force-pushed
the
fleet-spawn-parity
branch
from
August 25, 2026 14:52
1f243e4 to
606a86a
Compare
TheGreatAxios
force-pushed
the
fleet-task-wrapper
branch
from
August 25, 2026 14:52
241e46c to
00bc945
Compare
TheGreatAxios
force-pushed
the
fleet-spawn-parity
branch
2 times, most recently
from
August 25, 2026 16:11
61ef1d0 to
05ad41f
Compare
TheGreatAxios
force-pushed
the
fleet-task-wrapper
branch
from
August 25, 2026 16:12
7e9e47b to
1855463
Compare
Closed-director task() was a second full spawn engine. When a session store is present it now starts the worker through spawn_agent and blocks on wait_agents, so one mailbox owns completion. Custom AgentProfile lookup still uses the legacy await-run path.
…pper Director task() now routes through spawn_agent + wait_agents, which was misclassifying AbortError as failed:aborted, dropping Re-authenticate auth wording, and leaving the child running when the parent tool aborted. Map those outcomes back to the legacy fused-task parent contract and prettier the inherited agent-progress tip.
TheGreatAxios
force-pushed
the
fleet-task-wrapper
branch
from
August 25, 2026 16:40
1855463 to
45b7269
Compare
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
* Make director task() a spawn_agent plus wait_agents wrapper Closed-director task() was a second full spawn engine. When a session store is present it now starts the worker through spawn_agent and blocks on wait_agents, so one mailbox owns completion. Custom AgentProfile lookup still uses the legacy await-run path. * Preserve task cancel, auth, and abort contracts through the fleet wrapper Director task() now routes through spawn_agent + wait_agents, which was misclassifying AbortError as failed:aborted, dropping Re-authenticate auth wording, and leaving the child running when the parent tool aborted. Map those outcomes back to the legacy fused-task parent contract and prettier the inherited agent-progress tip.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
* Make director task() a spawn_agent plus wait_agents wrapper Closed-director task() was a second full spawn engine. When a session store is present it now starts the worker through spawn_agent and blocks on wait_agents, so one mailbox owns completion. Custom AgentProfile lookup still uses the legacy await-run path. * Preserve task cancel, auth, and abort contracts through the fleet wrapper Director task() now routes through spawn_agent + wait_agents, which was misclassifying AbortError as failed:aborted, dropping Re-authenticate auth wording, and leaving the child running when the parent tool aborted. Map those outcomes back to the legacy fused-task parent contract and prettier the inherited agent-progress tip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task()starts the worker throughspawn_agentand blocks onwait_agents, so one mailbox owns completion.fleetRecordsinstance betweentaskand the fleet verbs.Verification
bun run typecheck,bun run build, andbun run testpasstask()returning the worker report via the fleet mailbox