Skip to content

mountSlackTag: forward botToken to wireBot so Block Kit replies actually work - #10

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-5110-corbits-tag-mountslacktag-never-forwards-bottoken-to-wirebot
Aug 2, 2026
Merged

mountSlackTag: forward botToken to wireBot so Block Kit replies actually work#10
TheGreatAxios merged 1 commit into
mainfrom
cl-5110-corbits-tag-mountslacktag-never-forwards-bottoken-to-wirebot

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • wireBot's WireOptions.botToken (added in Reconcile TagThread.post(): convertMarkdown opt-out + Block Kit blocks/unfurl suppression #6 for the Block Kit reply path) was never threaded through from mountSlackTag, the package's actual entry point — mountSlackTag spreads MountSlackTagOptions (which has no top-level botToken, only slack.botToken) into wireBot(), so WireOptions.botToken stayed undefined for any host using the mount instead of calling wireBot directly.
  • Net effect before this fix: TagThread.post(text, { blocks }) silently degraded to plain-text-only for every real deployment (the documented "no bot token" fallback), even with a bot token configured.
  • Fix forwards the same token the Slack adapter itself authenticates with, mirroring the existing userLookup auto-wire one line above it.

Test plan

  • CI: bun run typecheck && bun run test
  • No new test: the passthrough is a one-line, unconditional forward with no branching logic of its own (the actual blocks/unfurl behavior it enables is already covered by wireBot's own test suite via a direct botToken option). mountSlackTag isn't practically unit-testable without a real Chat instance, matching this file's existing test coverage boundary (see index.test.ts).
  • Not run locally (sandboxed dev machine); tests will run in this repo's CI.

…lly work

wireBot's WireOptions.botToken (added in #6 for the Block Kit reply
path) was never threaded through from mountSlackTag, the package's
actual entry point — a host using the mount, rather than calling
wireBot directly, never saw the Block Kit / unfurl-suppression path
activate at all; TagThread.post(text, { blocks }) silently degraded to
plain text. Forward the same token the Slack adapter itself
authenticates with, same pattern as the existing userLookup auto-wire.
@TheGreatAxios
TheGreatAxios merged commit 6b59bc4 into main Aug 2, 2026
1 check passed
@TheGreatAxios
TheGreatAxios deleted the cl-5110-corbits-tag-mountslacktag-never-forwards-bottoken-to-wirebot branch August 2, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant