mountSlackTag: forward botToken to wireBot so Block Kit replies actually work - #10
Merged
TheGreatAxios merged 1 commit intoAug 2, 2026
Conversation
…lly work wireBot's WireOptions.botToken (added in #6 for the Block Kit reply path) was never threaded through from mountSlackTag, the package's actual entry point — a host using the mount, rather than calling wireBot directly, never saw the Block Kit / unfurl-suppression path activate at all; TagThread.post(text, { blocks }) silently degraded to plain text. Forward the same token the Slack adapter itself authenticates with, same pattern as the existing userLookup auto-wire.
TheGreatAxios
deleted the
cl-5110-corbits-tag-mountslacktag-never-forwards-bottoken-to-wirebot
branch
August 2, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wireBot'sWireOptions.botToken(added in Reconcile TagThread.post(): convertMarkdown opt-out + Block Kit blocks/unfurl suppression #6 for the Block Kit reply path) was never threaded through frommountSlackTag, the package's actual entry point —mountSlackTagspreadsMountSlackTagOptions(which has no top-levelbotToken, onlyslack.botToken) intowireBot(), soWireOptions.botTokenstayedundefinedfor any host using the mount instead of callingwireBotdirectly.TagThread.post(text, { blocks })silently degraded to plain-text-only for every real deployment (the documented "no bot token" fallback), even with a bot token configured.userLookupauto-wire one line above it.Test plan
bun run typecheck && bun run testwireBot's own test suite via a directbotTokenoption).mountSlackTagisn't practically unit-testable without a realChatinstance, matching this file's existing test coverage boundary (seeindex.test.ts).