Recover slices 2 and 3: logger debug seam and outgoing-text sanitization - #9
Merged
TheGreatAxios merged 2 commits intoAug 2, 2026
Conversation
warn() is for fail-soft conditions a host should see by default; debug() is for diagnostic-only lines a host can opt into without adopting a full log-level system. Optional so existing host loggers (which only implement warn) keep working unchanged.
sanitizeOutgoingText strips a single wrapping HTML tag, drops a leading leaked JSON/tool-call fence followed by real prose, unwraps a whole-reply fence around plain prose, and un-escapes markdown escape sequences. detectInfraErrorReply recognizes a raw infra-error dump (vs. prose that merely mentions one) so resolveOutgoingText can swap in a neutral, user-actionable message instead of letting it reach Slack verbatim; the original is logged for diagnosis. Wired into toTagThread's post() ahead of the convertMarkdown branch — sanitization targets text that should never have reached Slack in that shape at all, so it runs regardless of whether markdown conversion is requested.
TheGreatAxios
force-pushed
the
cl-5104-corbits-tag-add-loggerdebug-as-an-optional-diagnostic-only
branch
from
August 2, 2026 20:44
62f8311 to
7a6a855
Compare
TheGreatAxios
deleted the
cl-5104-corbits-tag-add-loggerdebug-as-an-optional-diagnostic-only
branch
August 2, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers two upstreaming slices that were lost to a stacked-merge mistake, not to any problem with the code itself.
What happened
The three slices were stacked — each branched from the previous rather than from
main. They were then squash-merged in order with branch deletion, which destroyed each subsequent pull request's base:mainand merged correctly.main.Both slices were therefore absent from
maindespite one showing as merged. No code was lost — #8's merge commit lives on this branch, so this branch now carries both.What this contains
Both were reviewed and green individually before the mistake.
Note for the rest of the stack
Remaining slices should branch from
mainand land one at a time, or be merged bottom-up without deleting branches until the whole stack is in. Stacked bases plus branch deletion is what caused this.