CL-6370: kill the grey slots, warm loader + designed empty states - #114
Merged
Merged
Conversation
Every page/room-level wait now renders the same shared treatment CL-6307
shipped for workbench setup — one honest headline plus a rotating tip,
never a bare Skeleton slab. Extracted that markup out of timeline.tsx
into chat-ui's new WorkbenchLoadingState (with a title override for
non-workbench surfaces and a delay threshold so a sub-200ms resolve
never flashes an intermediate frame) and reused it for:
- the route-level Suspense fallback in app-shell.tsx (was a bare
page-fill div)
- chat-workspace's workbench-list, message-timeline, and tenant-loading
states (were bare Skeleton slabs — the source of the "grey rectangle"
on opening a workbench)
- routine-panel's routines/trace/runs/tasks panels (were bare Skeleton
slabs)
Also fixes the empty-agent-DM "blank void": settingUpAgent was
permanently true for every agent chat (it never checked whether the
agent had actually joined), so an agent DM with zero messages could
never show anything but the setup loader. It now clears once the agent
participant appears, and a genuinely empty-but-ready agent DM leads
with the agent's own name ("Say hello to Myra") instead of generic
timeline copy.
Files/Skills/Agents pages already had designed RichEmptyState
treatments with a primary action, so those were left alone.
TheGreatAxios
force-pushed
the
cl-6370-loading
branch
from
August 20, 2026 13:36
9eae5cd to
0f25562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkbenchLoadingState(chat-ui), with a title override and a 200ms flash-prevention delay, and replaced every bareSkeleton/page-fillgrey slab in scope with it: the app-shell route Suspense fallback, chat-workspace's workbench-list/message-timeline/tenant-loading states, and routine-panel's routines/trace/runs/tasks panels.settingUpAgentnever actually checked whether the agent had joined, so an empty agent DM could only ever render the setup loader, forever. It now clears once the agent participant appears, and a ready-but-empty agent DM leads with the agent's own name ("Say hello to Myra") instead of generic copy.RichEmptyStatetreatments with a primary action — left untouched.Before/after inventory
app-shell.tsx)<div className="page-fill" aria-busy>WorkbenchLoadingState<Skeleton className="query-skeleton">WorkbenchLoadingState<Skeleton className="query-skeleton">WorkbenchLoadingState<Skeleton className="query-skeleton">WorkbenchLoadingState<Skeleton className="query-skeleton">WorkbenchLoadingStatewith a per-panel titleEmptyState"No messages yet / Say something…"RichEmptyStatewith description (+ action on Skills)<Skeleton className="shell-activity-skeleton">(6rem nav strip)Skeletonsized to match final row/card layoutTest plan
packages/chat-ui:bun run typecheckandbun test(590 pass)apps/web:bun run typecheckandbun run test(build + 578 pass)bun run check:ui-vocabulary— clean