CL-6368: shell chrome parity + team space isn't a workbench - #116
Merged
Merged
Conversation
/workbenches currently lists the requested tenant's own aggregate row alongside its child workbenches — for the account root that row reads as a workbench named after the account itself. Updates the fixture to expect it excluded (CL-6368).
The account's root tenant (parentId null) is a container, not a workbench itself — real workbenches are its child tenants (CL-6089). /workbenches was including its own rollup-of-itself row (e.g. "alice's workbench") in the activity-by-workbench chart, alongside the actual children. Exclude it (CL-6368).
…bench' The account's one root tenant is a container real workbenches live under (CL-6089), never a workbench itself. Naming it "…'s workbench" at mint time is what made it show up looking like one everywhere workbenches are listed. Dev-data note: only fresh signups get the corrected name — no rename migration for existing dev tenants (CL-6368).
…tility rail pages Row selection is asserted against a <tr>, not a <button>, ahead of Skills switching its list from SidebarItemRow to the same Table row idiom Agents/Library already use. New chrome-consistency coverage DOM-asserts each utility page (Files, Skills, Agents) renders the shared StageTopBar/Table components, not bespoke stand-ins (CL-6368).
Skills' list rendered rows with SidebarItemRow (the Settings-nav row component) and a bespoke search box instead of the Table/TableRow and LibrarySearchInput every other utility rail page already uses — the one visible chrome mismatch across /files, /skills, /agents (CL-6368).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/skillslist rows now use the sameTable/TableRowidiom andLibrarySearchInputthat/filesand/agentsalready use, replacing theSidebarItemRow-based list and bespoke search box that made the page read differently from its siblings./filesand/agentswere already on the sharedStageTopBar+PageShellchrome and needed no change there; active nav-rail state was already correct on all three.parentId === null) is a container real workbenches live under as child tenants (CL-6089), never a workbench itself.GET /workbenches(packages/insights) no longer includes the requested tenant's own rollup-of-itself row, so Insights' "Activity by workbench" chart only ever lists real child workbenches.WorkbenchList/listWorkbenchesalready queries workbench-kind child tenants directly rather than walking the tenant hierarchy, so it was never affected by this conflation.Test plan
apps/web:bun test— 581 passpackages/insights:DATABASE_URL=... bun test— 59 pass (includes the DB-gated/workbenchesscope test updated to expect the team space excluded)bun run check:ui-vocabulary— ok ("team space" is a banned synonym per CL-6089; renamed the mint copy to avoid it)bun run check:react-ui-drift— oktsc --noEmitclean forapps/webandpackages/insightsprettier --checkclean on every changed file (repo-widebun run linthas 6 pre-existing formatting warnings and 3 pre-existing eslint errors in files this PR never touches — confirmed viagit diff --statagainst those paths)