Skip to content

CL-6368: shell chrome parity + team space isn't a workbench - #116

Merged
TheGreatAxios merged 5 commits into
mainfrom
cl-6368-shell-polish
Aug 20, 2026
Merged

TheGreatAxios merged 5 commits into
mainfrom
cl-6368-shell-polish

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Skills chrome parity: /skills list rows now use the same Table/TableRow idiom and LibrarySearchInput that /files and /agents already use, replacing the SidebarItemRow-based list and bespoke search box that made the page read differently from its siblings. /files and /agents were already on the shared StageTopBar + PageShell chrome and needed no change there; active nav-rail state was already correct on all three.
  • Team space is not a workbench (CL-6368): the account's root tenant (parentId === null) is a container real workbenches live under as child tenants (CL-6089), never a workbench itself.
    • GET /workbenches (packages/insights) no longer includes the requested tenant's own rollup-of-itself row, so Insights' "Activity by workbench" chart only ever lists real child workbenches.
    • Onboarding now mints the account's root tenant under its own name ("Ada's team") instead of "Ada's workbench", which is what made it read like a workbench everywhere workbench names get listed.
    • Swept the sidebar/listings: WorkbenchList/listWorkbenches already queries workbench-kind child tenants directly rather than walking the tenant hierarchy, so it was never affected by this conflation.
    • No rename migration for existing dev/demo tenants — only fresh signups get the corrected name, per the repo's dev-data wipe convention.

Test plan

  • apps/web: bun test — 581 pass
  • packages/insights: DATABASE_URL=... bun test — 59 pass (includes the DB-gated /workbenches scope test updated to expect the team space excluded)
  • bun run check:ui-vocabulary — ok ("team space" is a banned synonym per CL-6089; renamed the mint copy to avoid it)
  • bun run check:react-ui-drift — ok
  • tsc --noEmit clean for apps/web and packages/insights
  • Scoped prettier --check clean on every changed file (repo-wide bun run lint has 6 pre-existing formatting warnings and 3 pre-existing eslint errors in files this PR never touches — confirmed via git diff --stat against those paths)

/workbenches currently lists the requested tenant's own aggregate row
alongside its child workbenches — for the account root that row reads
as a workbench named after the account itself. Updates the fixture to
expect it excluded (CL-6368).
The account's root tenant (parentId null) is a container, not a
workbench itself — real workbenches are its child tenants (CL-6089).
/workbenches was including its own rollup-of-itself row (e.g. "alice's
workbench") in the activity-by-workbench chart, alongside the actual
children. Exclude it (CL-6368).
…bench'

The account's one root tenant is a container real workbenches live
under (CL-6089), never a workbench itself. Naming it "…'s workbench"
at mint time is what made it show up looking like one everywhere
workbenches are listed. Dev-data note: only fresh signups get the
corrected name — no rename migration for existing dev tenants (CL-6368).
…tility rail pages

Row selection is asserted against a <tr>, not a <button>, ahead of
Skills switching its list from SidebarItemRow to the same Table row
idiom Agents/Library already use. New chrome-consistency coverage
DOM-asserts each utility page (Files, Skills, Agents) renders the
shared StageTopBar/Table components, not bespoke stand-ins (CL-6368).
Skills' list rendered rows with SidebarItemRow (the Settings-nav row
component) and a bespoke search box instead of the Table/TableRow and
LibrarySearchInput every other utility rail page already uses — the
one visible chrome mismatch across /files, /skills, /agents (CL-6368).
@TheGreatAxios
TheGreatAxios merged commit a4f98ee into main Aug 20, 2026
0 of 2 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-6368-shell-polish branch August 25, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant