Skip to content

CL-6362: Routines becomes a global-only surface #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 2 commits into from
Aug 20, 2026
Merged

CL-6362: Routines becomes a global-only surface #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
891e872
Add tests for the global Routines page and removed per-workbench chrome
TheGreatAxios Aug 20, 2026
47f88d8
CL-6362: Routines becomes a global-only surface
TheGreatAxios Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions apps/web/src/pages/chat-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import {
isWorkbenchSettingsPath,
} from "../workbench-path";
import { reportWorkbenchNotFound } from "../workbench-not-found-event";
import { workbenchInsightsPath } from "../insights-deeplinks";
import { ONBOARDING_PATH } from "../routes";
import {
useProviderHealthBanner,
Expand Down Expand Up @@ -227,27 +226,11 @@ export function ChatPage({
{...(blockResponses !== undefined ? { blockResponses } : {})}
{...(connectGithubActions !== undefined ? { connectGithubActions } : {})}
listMembers={listMembers}
// The header's Routines affordance and `/run`: the panel's default
// list view, beside this conversation — never a `/routines` hop
// (CL-6139). Bound to this workbench so the list's own "New routine"
// row still targets this conversation's agent/workbench.
onOpenRoutines={() =>
openRoutine({
view: "list",
...(workbenchId !== null ? { workbenchId } : {}),
})
}
// The header's Insights affordance: this conversation's own scoped
// timeline, never the global landing. Passes the workbench id as-is —
// the route itself resolves the workbench's workbench tenant (see
// `insights-workbench-scope.ts`), since a workbench id is never a
// tenant id.
onOpenInsights={() => {
if (workbenchId === null) return;
navigate(workbenchInsightsPath(workbenchId));
}}
// `/routine`: opens the editor directly on a brand-new routine
// bound to this workbench.
// bound to this workbench. Routines and Insights (CL-6362, CL-6099)
// are global-only pages now, reached from the shell rail — no
// per-workbench header button or `/run` command opens a scoped view
// of either here.
onCreateRoutineInSpace={(inSpaceWorkbenchId) =>
openRoutine({ routineId: null, workbenchId: inSpaceWorkbenchId })
}
Expand Down
Loading
Loading