CL-6381: warm loader everywhere + app error boundary (UI polish slice 1) - #129
Merged
Merged
Conversation
Adds the one error boundary the app never had (a render error used to leave the reader on a blank white page), and swaps every bare spinner, "Loading…" text, and empty PageShell wait for WorkbenchLoadingState so the app has one wait treatment instead of four. KPI tiles get a real shimmer instead of an ellipsis; the sidebar's activity loader and the library preview header now match their real content's shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements punch-list slice 1 (items 1.1-1.9) from the whole-shell UI critique pass — the app's error boundary and every bare/inconsistent loading treatment.
AppErrorBoundary, the app's first error boundary, wrapping<Root/>inmain.tsx. Renders the EmptyState "This screen hit a snag" + Reload, logs via@corbits/client-log(never console)..onboarding-spinnerring →WorkbenchLoadingState.QueryView's"block"case gains an optionalloadingContentoverride (api-query can't import chat-ui'sWorkbenchLoadingStatedirectly — chat-ui depends on api-query); wired into workbench-settings' full-stage surface.PageShellduring fetch now renders the warm loader inside the shell.WorkbenchLoadingState, with copy "Getting your workbench ready…".WorkbenchLoadingStatewhile creating.Skeletonshimmer instead of an ellipsis.No skips — none of slice 1 was already fixed on main. Rebased onto main to pick up the Phosphor icon swap (#118+) and CL-6383's chip/affordance work, which landed mid-task; resolved import conflicts in favor of
@corbits/icons.Test plan
bun run typecheckclean inapps/web,packages/chat-ui,packages/api-querybun testgreen in all three (only pre-existing, unrelatedtailwind-build.test.tsfailures remain — they require a priorbun run buildand fail identically on main)AppErrorBoundaryred/green test: healthy tree passes through, throwing child renders the EmptyStateQueryViewandinsights-pagetests for the newloadingContentprop and KPI shimmerprettier --checkandeslintclean on every changed file (pre-existing unrelated warnings only)