Chat motion: dedupe --chat-ease onto react-ui's real easing tokens - #243
Merged
Conversation
The chat surface was inventing its own easing curve instead of consuming react-ui's --ease-out, and the composer's in-place height transition used an entrance curve where DESIGN.md calls for --ease-in-out. Also brings the loading-tip fade under DESIGN.md's 300ms motion ceiling (was 400ms).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/chat-ui/src/styles.cssinvented its own--chat-easecubic-bezier instead of consuming react-ui's--ease-out(CL-6487 finding Bench chat defaults with per-channel context-window overrides #3). It now aliasesvar(--ease-out, ...), keeping the old curve only as a fallback for contexts without react-ui's theme stylesheet loaded.--ease-in-outper DESIGN.md's explicit guidance, instead of the entrance curve every other--chat-easetransition in this file uses.chat-workbench-loading-tip-fadewas animating at 400ms, over DESIGN.md's 150–300ms motion ceiling; dropped to 280ms.Context / audit findings already resolved on main
Investigated CL-6487/6488/6489 (the audit tickets backing this lane) against current
main. Three of CL-6488's four "chat canon" criticals are already fixed by a prior commit (3429637b, merged via PR #221) even though the Linear ticket is still marked Todo:.chat-bubblehas no border/background/radius, and there is norow-reverse/[data-own]styling anywhere in the stylesheet.width: 100%in.chat-composer-stack/.chat-composer.--primary— it'svar(--muted-foreground); only the failed state gets color, matching DESIGN.md's "color reserved for failure" rule.Known gap (not fixed here — flagging honestly)
.whenslot shows"10:03 · opus-5"for agent turns.MessageSender(packages/chat-ui/src/api.ts) has nomodelfield, and no model is persisted onto a message anywhere inpackages/chattoday (it's resolved per-turn for the LLM call ininference-preferences.ts/platform-adapter.tsbut never attached to the posted message). Closing this needs a wire schema change plus orchestrator work inpackages/chat, which is out of this lane'schat-ui-only scope and risks colliding with sibling lanes — flagging rather than rushing a partial fix..onboarding-phase-in320ms) are outside the chat surface (Settings/Plugins/sidebar chrome) — left for the owning lane.Test plan
bun installin the fresh worktree (was missing@happy-dom/global-registrator), thenbun testinpackages/chat-ui: 650 pass / 0 failbunx prettier --writeon the changed file (no changes needed — already formatted)timeline.tsx,tool-activity.ts/tool-activity-view.tsx,composer.tsx,chat-page.tsx,id-leak-guard.tsagainst mock-spec §12 — no further chat-scope gaps found beyond the model-attribution item above