Consolidate StatGridItem radius override; widen search hit target - #259
Merged
Merged
Conversation
Two local overrides for react-ui's hardcoded StatGridItem rounding (insights and mission-control) duplicated the same zero-radius re-assertion; replace both with one selector so every consumer, including Evals, stays square without a third copy. Also widen .stage-search-button to the 40px floor for a primary chrome control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A design review flagged three defects against
origin/main. Re-verifying on currentorigin/main(2a0c7b1) found two of the three already fixed by prior merges:/evalsunreachable — already wired:routes.tsxregistersEvalsRouteinAPP_ROUTES/NAV_ROUTES,sidebar.tsxhas the footer row, andtest/routes.test.tsxasserts both. Landed inb2c1b21a..insights-running-now*/.insights-flight*rules exist inapp.css:2622-2688, using the established hairline-border/var(--card)panel language. Landed in the same commit as the feature (5d97bb98).The third was real and is fixed here:
StatGridItemradius patched twice locally.@corbits/react-ui'sStatGridItemhardcodesrounded-lginstead of consumingvar(--radius), and two authors each wrote a page-scoped zero-radius override (.insights-layout [data-slot="stat-grid-item"],.mission-control-layout [data-slot="stat-grid-item"]). Evals uses the same component with no override, so its tiles were rounded while its neighbors were square. Since--radius: 0is already an app-wide rule (not per-page), I collapsed both copies into one selector —[data-slot="stat-grid-item"] { border-radius: 0; }— which now covers Insights, Mission Control, Evals, and any future consumer without adding a third local copy. react-ui is a separate repo I can't land a fix in from here, so this is the from-this-side consolidation rather than an upstream patch; the upstream gap (hardcodedrounded-lg) is worth a ticket there.Also fixed while in the area (minor, time-permitting per the ask):
.stage-search-buttonwas1.9remsquare — 28.5px at the 15px root, under the 40px hit-target floor for a primary chrome control. Bumped it and its collapsed.stage-searchwrapper to2.75rem(41.25px).Test plan
bun test test/routes.test.tsx— 37 pass (confirms/evalsregistered + reachable from rail and palette)bun test test/evals-route.test.tsx test/insights-page.test.tsx test/insights-route.test.tsx test/mission-control-page.test.tsx— 47 passbunx prettier --write apps/web/src/app.css— no changes needed