CL-6529: Fix false inference-catalog claim, posix-tools.md fiction, fold structural checks into check - #262
Merged
Merged
Conversation
…x posix-tools.md fiction, fold structural checks into check model-seeding.md claimed @intx/inference-catalog does not exist; it is pinned in package.json and imported directly by packages/inference-catalog/src/offering-capabilities.ts. Corrected the claim and described how the package is actually consumed. posix-tools.md described @corbits/posix-tools as shipped, with a tool list, but the package exists nowhere in the tree. Rewrote it to state plainly nothing ships under that name, point at the real upstream @intx/tools-posix, and mark the rest as an unimplemented design note. bun run check only ran typecheck/lint/test; the twelve check:* structural gates ran only in CI, and three weeks of git history show repeated hotfix/format-only commits a local check would have caught. Added check:structural (the eleven lightweight gates) and folded it into check. check:packages builds and packs every workspace package and is genuinely heavy, so it stays out of the default check; added check:all for full CI parity locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes, timeboxed to the dangerous-doc audit — no wider docs cleanup (that's a separate scheduled pass; sibling PR #260 owns AGENTS.md/DESIGN.md, untouched here).
docs/model-seeding.md:65-66claimed@intx/inference-catalog"does not exist upstream or on npm (confirmed vianpm view)". It does: pinned inpackage.jsonat0.3.0, imported directly atpackages/inference-catalog/src/offering-capabilities.ts:29, and listed inVENDORED.mdamong the trees retired to that npm publish. A confident negative claim with fake verification is the worst shape a doc bug takes — it authorizes building something the platform already ships. Corrected the paragraph and traced how the package is actually consumed today (seedCatalog→capabilitiesForDeployment→catalogProviders). Checked the rest of the section for anything else resting on the false premise — nothing else did.docs/posix-tools.mddescribed@corbits/posix-toolsin the present tense with a tool list; the package doesn't exist anywhere in the tree. Rewrote it to say so plainly, point at the real upstream package (@intx/tools-posix— itssidecar-bundle:run_shelltool already shows up inpackages/mocks/src/ollama/scenarios.tsand a vendored hub-sessions test fixture), and mark the remaining content unambiguously as an unimplemented design proposal.Structural check drift.
bun run checkran only typecheck/lint/test; the twelvecheck:*structural gates ran only in CI. Three weeks of history show repeated hotfix commits (check:licenses,check:ui-vocabulary,check:tailwind-source,check:packages,check:killdates,check:react-ui-drift) plus six format-only "so lint passes on main" commits — all round-trips a localcheckwould have caught. Addedcheck:structural(the eleven lightweight gates) and folded it intocheck.check:packagesis deliberately excluded from the defaultcheck. It builds and packs every workspace package in isolation (bun pm pack+ consumption from a staging dir) — genuinely heavy, and the dev machine has been memory-constrained all week. Folding it in wholesale would makecheckslow enough that people stop running it, which defeats the point. Addedcheck:all(check+check:packages) for anyone who wants full CI parity locally.Linear: CL-6529
Test plan
bunx prettier --writeon all three changed files (no changes needed — already formatted)python3 -c "import json; json.load(open('package.json'))"— valid JSON@intx/inference-catalogpin, import, and VENDORED.md entry directly in the tree before editing@corbits/posix-toolshas zero references outside the doc, and@intx/tools-posixis real (referenced in test fixtures)bun run checklocally not run — dev machine memory-constrained per team convention; relying on CI's existing per-gate steps, which are unchanged)