Files: legible scope chips, honest upload confirmation, bottom-right toast, full-height detail pane - #276
Merged
Merged
Conversation
…ion, and detail-pane height Covers four owner-reported gaps on the Files page: the scope chips reading as one ambiguous group, an upload with no success feedback, the app-wide toast sitting bottom-center, and the file detail pane floating short in an otherwise empty page.
…toast, full-height detail pane - The top bar's clear-selection action no longer says bare "All" beside "All workbenches" — it reads "Back to files", an action rather than a third filter option. The workbench/all-workbenches pair is now visually one bordered segmented control (the same idiom `ViewToggle` already uses in this bar), so the one real scope question reads as one control. - A completed upload now confirms the title the server actually stored, not the local file name the browser sent, and stays silent (surfacing the failure instead) when the upload endpoint reports one. - The app's one `<Toaster>` mount (main.tsx) now positions bottom-right; a react-ui override that hardcoded horizontal centering is cancelled for that position in app.css so the toast actually lands where it claims to. - The file preview pane now fills the available height instead of floating as a short panel in an otherwise empty page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four owner-reported fixes on the Files page (CL-6563):
ViewTogglealready uses for rows/grid in this same bar), so it reads as one control answering one question. Checked Skills, Agents, Routines, and Insights for the same pattern: none of them have it — Insights has its own, already-legible workbench-scope switcher (a different pattern). The ambiguous row was unique to Files.<Toaster>mount (main.tsx) now passesposition="bottom-right". A hardcoded centering rule in the vendored@corbits/react-uistylesheet fights any non-center position with!important; a higher-specificity override inapp.csscancels it for the right-position case. The existing "one toast system" invariant test (CL-6372) is untouched and still passes.Test plan
apps/web/test/library-page-selection.test.tsx— new coverage for the grouped scope control, the relabeled clear-selection action, and the full-height detail paneapps/web/test/library-upload-confirmation.test.tsx— new: a completed upload confirms the server's title, a failed upload surfaces the error and never fakes a success toastapps/web/test/toast-single-system.test.tsx— new case pinning the app's Toaster to bottom-right; existing CL-6372 invariant tests untouched and passingapps/webtest suite (840 tests),typecheck,lint, andcheck:tailwind-sourceall passhttps://linear.app/abklabs/issue/CL-6563/files-page-legible-scope-chips-honest-upload-confirmation-bottom-right