Skip to content

Onboarding: skip escape hatch + Ollama connect coverage - #285

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-onboarding-ollama
Aug 22, 2026
Merged

Onboarding: skip escape hatch + Ollama connect coverage#285
TheGreatAxios merged 2 commits into
mainfrom
cl-onboarding-ollama

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Investigated the report that onboarding's "Bring your own AI" step has no local/self-hosted option and no way past it. On origin/main, apps/web/src/onboarding.ts / onboarding-page.tsx already carry full Ollama support (CL-6146: URL-shaped card, http://localhost:11434 default, /v1 base-URL normalization) — the live repro this ticket describes likely hit a deploy that predates that landing. This PR closes the two gaps that were still real:
  • Adds end-to-end frontend coverage for the Ollama card: selecting it prefills the default URL, submitting sends it as baseURL with the fixed Ollama placeholder key, and the tenant lands on the workbench with a usable model. Previously only the backend (packages/onboarding/test/complete-credential.test.ts) covered this.
  • Adds a "Skip for now" control to the credential step — an account with no provider ready yet (URL unreachable, no key in hand) can now proceed to / instead of being blocked. Provisioning already treats this as bench_unseeded, an anticipated state; the no-usable-model banner from CL-6568: tell people before they type, and don't lie when it fails #280 (CL-6568) is what tells the person, honestly, that a connection still needs finishing.

Test plan

  • bun test test/onboarding.test.tsx — 49 pass, including the two new tests
  • bunx tsc --noEmit on apps/web — clean
  • bunx eslint on changed files — no new warnings (one pre-existing, unrelated warning on onboarding-page.tsx)
  • bunx prettier --check on changed files — clean
  • bun test (full apps/web suite) — 846 pass / 3 fail, all 3 pre-existing and unrelated (network-dependent tests hitting ECONNREFUSED, and a tailwind-build test that needs a prior bun run build)

Linear: CL-6576

Covers the Ollama (local) provider card end to end (default URL
prefilled, submitting sends it as baseURL with the fixed placeholder
key, and the account lands on the workbench) and a "Skip for now"
control that hands off without hitting the credential-complete route.
…nect yet

Bring-your-own-AI already covers Ollama and every other supported
provider, but the credential step had no way through for someone whose
provider isn't ready yet (a local Ollama that isn't running, or no key
in hand at all). Provisioning already treats that as bench_unseeded,
not an error, so skipping just hands off to the workbench the same way
a confirmed credential does — the no-usable-model banner there is what
tells the person, honestly, that a connection still needs finishing.
@TheGreatAxios
TheGreatAxios merged commit 19fb9d2 into main Aug 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant