Onboarding: skip escape hatch + Ollama connect coverage - #285
Merged
Conversation
Covers the Ollama (local) provider card end to end (default URL prefilled, submitting sends it as baseURL with the fixed placeholder key, and the account lands on the workbench) and a "Skip for now" control that hands off without hitting the credential-complete route.
…nect yet Bring-your-own-AI already covers Ollama and every other supported provider, but the credential step had no way through for someone whose provider isn't ready yet (a local Ollama that isn't running, or no key in hand at all). Provisioning already treats that as bench_unseeded, not an error, so skipping just hands off to the workbench the same way a confirmed credential does — the no-usable-model banner there is what tells the person, honestly, that a connection still needs finishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/main,apps/web/src/onboarding.ts/onboarding-page.tsxalready carry full Ollama support (CL-6146: URL-shaped card,http://localhost:11434default,/v1base-URL normalization) — the live repro this ticket describes likely hit a deploy that predates that landing. This PR closes the two gaps that were still real:baseURLwith the fixed Ollama placeholder key, and the tenant lands on the workbench with a usable model. Previously only the backend (packages/onboarding/test/complete-credential.test.ts) covered this./instead of being blocked. Provisioning already treats this asbench_unseeded, an anticipated state; the no-usable-model banner from CL-6568: tell people before they type, and don't lie when it fails #280 (CL-6568) is what tells the person, honestly, that a connection still needs finishing.Test plan
bun test test/onboarding.test.tsx— 49 pass, including the two new testsbunx tsc --noEmitonapps/web— cleanbunx eslinton changed files — no new warnings (one pre-existing, unrelated warning ononboarding-page.tsx)bunx prettier --checkon changed files — cleanbun test(fullapps/websuite) — 846 pass / 3 fail, all 3 pre-existing and unrelated (network-dependent tests hittingECONNREFUSED, and a tailwind-build test that needs a priorbun run build)Linear: CL-6576