Skip to content

CL-6589: run-all tests must not inherit the caller's gate config #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheGreatAxios merged 1 commit into from
Aug 22, 2026
Merged

CL-6589: run-all tests must not inherit the caller's gate config #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion scripts/run-all.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,17 @@ async function runProbe(
const logPath = join(workspace, `probe-${logCounter}.log`);
await writeFile(logPath, "");

// These cases assert the runner's own fan-out over a fixture workspace, so
// they must not inherit the caller's gate configuration. A developer with
// WORKBENCH_CHECK_SINCE exported resolves the filter against the real repo's
// git rather than the fixture, every probe package reads as unaffected, and
// the runner correctly reports "nothing affected" — failing tests that are
// actually about something else. A case that wants either variable sets it
// through `extraEnv`.
const { WORKBENCH_CHECK_SINCE: _since, ...ambient } = process.env;
const child = Bun.spawn(["bun", "run", RUNNER, script], {
cwd: workspace,
env: { ...process.env, PROBE_LOG: logPath, ...extraEnv },
env: { ...ambient, PROBE_LOG: logPath, ...extraEnv },
stdout: "pipe",
stderr: "pipe",
});
Expand Down
Loading