CL-6645: exclude ollama.com cloud-proxy models from local Ollama catalogs - #317
Merged
Conversation
…atalog A URL-kind Ollama box answers /api/tags with *-cloud models whether or not it is signed in to ollama.com, but every actual call to one needs an ollama.com account this catalog has no way to supply — that's what put a keyed cloud upstream into an otherwise-local, unauthenticated inference chain (CL-6645).
fetchOllamaModelCatalog seeded every model a box's /api/tags reported, including *-cloud names that merely proxy to ollama.com. Those need a signed-in ollama.com account and their own credential this catalog never collects, so pinning one produces a chain with a keyed upstream next to an otherwise-unauthenticated local box (CL-6645).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 3 of CL-6645 (child of the CL-6644 chain).
*-cloud/:cloudmodels on a URL-kind Ollama box proxy to ollama.com and require an account the catalog cannot supply — seeding them is what let a keyed upstream into an otherwise fully-local source chain (surfacing asAPI key is invalid [HTTP 401]).fetchOllamaModelCatalognow excludes them.Tests first (red/green), hub-client 167/167, fast gate green. Fixes 1 and 2 of CL-6645 are deliberately not here: the sidecar's frozen-sources reconcile is CL-6648 (nontrivial, exact pointers filed), and per-source failover on credential_failure lives in unvendored
@intx/agent(upstream ask documented, not reimplemented).Linear: CL-6645